Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to clear focus of any widgets contained by an Expander #74

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Pieter-Dewachter
Copy link
Contributor

When an Expander contains widget that can be focused, a visual glitch appears when hiding the contents of the Expander. This PR fixes the issue by clearing the focus of any children widgets when the contents are invisible. See the following screenshot for how the visual glitch looks like:
image

Copy link

@oclero oclero changed the base branch from master to dev December 11, 2024 16:12
@oclero
Copy link
Owner

oclero commented Dec 11, 2024

Is it the only way? It seems a bit hacky, especially if the focus policy changes (for whatever reason) between the two states.

@Pieter-Dewachter
Copy link
Contributor Author

I'm not sure, but I do agree it's a little bit hacky. If there's another way I'm definitely open for it, but for now I don't really know.
I tried using setEnabled but that didn't do the trick unfortunately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants