Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presence of .merlin.skip-if-not-cwd skips config in dir #1870

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

jonahbeckford
Copy link
Contributor

Mitigation for #1869

414 branch: https://github.com/jonahbeckford/merlin/tree/feature-skip-if-not-cwd-414

Testing (see Reproduction in #1869):

# Base case has a failure because there is a us\SonicScoutBackend\dune-project
PS> ... ocamlmerlin.exe single dump-configuration -filename us\SonicScoutBackend\src\SonicScout_Std\Aws_manager.ml | jq '.value.merlin.failures, (.value.merlin.build_path | length)'
[
  "No config found for file us/SonicScoutBackend/src/SonicScout_Std/Aws_manager.ml. Try calling 'dune build'."
]
0

# Adding .merlin.skip-if-not-cwd to subproject SKIPS .merlin and dune-project
PS> echo "" > .\us\SonicScoutBackend\.merlin.skip-if-not-cwd
PS> ... ocamlmerlin.exe single dump-configuration -filename us\SonicScoutBackend\src\SonicScout_Std\Aws_manager.ml | jq '.value.merlin.failures, (.value.merlin.build_path | length)'
[]
227

# Adding .merlin.skip-if-not-cwd to root project DOES NOT SKIP .merlin or dune-project
PS> echo "" > .merlin.skip-if-not-cwd
PS> ... ocamlmerlin.exe single dump-configuration -filename us\SonicScoutBackend\src\SonicScout_Std\Aws_manager.ml | jq '.value.merlin.failures, (.value.merlin.build_path | length)'
[]
227

voodoos and others added 30 commits May 31, 2024 14:08
…lit-protocol

Extract commands from new protocol inside a dedicated library
Add a `find_command_opt` alternative to `find_command` that does not raise
@jonahbeckford jonahbeckford force-pushed the feature-skip-if-not-cwd branch from 9cbcb3c to e09ade6 Compare December 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants