Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Igniter task for installing Oban #1208

Merged
merged 8 commits into from
Dec 29, 2024
Merged

Igniter task for installing Oban #1208

merged 8 commits into from
Dec 29, 2024

Conversation

sorentwo
Copy link
Member

@sorentwo sorentwo commented Dec 26, 2024 •
edited
Loading

This adds the skeleton of a task with a few basic options.

  • Add the oban dependency
  • Configure the otp app
  • Configure testing
  • Add Oban to the supervision tree
  • Import oban as into formatter deps
  • Generate ecto migration
  • Automatically change the engine based on the repo adapter
  • Document using mix igniter.install oban as a single step install
  • Test the task (https://hexdocs.pm/igniter/Igniter.Test.html)

@sorentwo sorentwo added kind:enhancement New feature or request area:oss Related to Oban OSS labels Dec 26, 2024
@sorentwo sorentwo marked this pull request as ready for review December 27, 2024 12:57
@sorentwo sorentwo changed the title Begin igniter task for installing Oban Igniter task for installing Oban Dec 27, 2024
sorentwo
sorentwo commented Dec 27, 2024
View reviewed changes
.credo.exs Outdated Show resolved Hide resolved
guides/introduction/installation.md Show resolved Hide resolved
test/mix/tasks/oban.install_test.exs Outdated Show resolved Hide resolved
@zachdaniel
Copy link
Contributor

Looks great!

@sorentwo sorentwo merged commit 5fa5523 into main Dec 29, 2024
2 checks passed
@sorentwo sorentwo deleted the igniter-install branch December 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
area:oss Related to Oban OSS kind:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorentwo @zachdaniel