Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packit with currently supported upgrade paths #853

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

fernflower
Copy link
Member

That' an adoptation of leapp-repository's packit update and refactoring introduced in PR1176.

OAMG-10855

Copy link

github-actions bot commented Mar 1, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and leapp-repository*master* as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@fernflower fernflower force-pushed the updateupgradepaths branch from 5d616e9 to 338b5b8 Compare March 1, 2024 14:05
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

1 similar comment
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@fernflower fernflower force-pushed the updateupgradepaths branch from 338b5b8 to 5e218f0 Compare March 1, 2024 14:31
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

That' an adoptation of leapp-repository's packit update and
refactoring introduced in PR1176.

OAMG-10855
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

1 similar comment
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@fernflower fernflower force-pushed the updateupgradepaths branch from 5e218f0 to 9cc0503 Compare March 1, 2024 15:28
@fernflower
Copy link
Member Author

Hmm thats weird, packit validate is happy with the config when run locally

(.venv) [ivasilev@ivasilev-thinkpadp1gen4i packit]$ packit validate-config ../leapp/.packit.yaml 
fedpkg is not executable or in any path
2024-03-01 16:35:27.935 schema.py         WARNING The 'metadata' key in jobs is deprecated and can be removed. Nest config options from 'metadata' directly under the job object.
2024-03-01 16:35:27.935 schema.py         WARNING The 'metadata' key in jobs is deprecated and can be removed. Nest config options from 'metadata' directly under the job object.
2024-03-01 16:35:27.942 validate_config.py INFO   .packit.yaml is valid and ready to be used

@pirat89
Copy link
Member

pirat89 commented Mar 4, 2024

/packit build

@pirat89
Copy link
Member

pirat89 commented Mar 4, 2024

/packit copr-build

@fernflower fernflower requested review from abadger and a team March 5, 2024 13:57
Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and seems working

@pirat89 pirat89 merged commit a504470 into oamg:master Mar 5, 2024
20 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants