Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actor for mysql migration RHEL9->RHEL10 #1321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SlouchyButton
Copy link

Basic actor that just checks that the mysql-server package is installed and inform user if so.

There are incompatibilities, so there is an article attached describing the process (the article is WIP)

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@SlouchyButton
Copy link
Author

/packit copr-build

@SlouchyButton
Copy link
Author

Added configuration checks, so the user is informed that current MySQL configuration won't be compatible with newer MySQL present in RHEL 10.

When incompatible config is detected, severity is also raised to HIGH, as proceeding will result in mysqld failing to launch until issues with config are resolved.

@pirat89
Copy link
Member

pirat89 commented Jan 8, 2025

@SlouchyButton hi \o thanks for the contribution! regarding the severity, if I understand it right, the worst scenario here is that mysqldb will not be launched on the new system - will not be working - until they fix the configuration. fro mthis point I do not think we should use high severity.

  • High - Very likely to result in a deteriorated system state.
  • Medium - Can impact both the system and applications.
  • Low - Should not impact the system but can have an impact on applications.
  • Info - Informational with no expected impact to the system or applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants