Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1682] Remove debug messages when comparing c2r versions #1446

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

danmyway
Copy link
Member

@danmyway danmyway commented Dec 6, 2024

The tool version check iterates over all the versions available in the convert2rhel repository.
While doing so, it provides unnecessary information in the debug messages.
Remove the debug messages to keep the output less polluted.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway danmyway requested a review from a team as a code owner December 6, 2024 13:20
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (9959824) to head (675f28f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
- Coverage   96.11%   96.11%   -0.01%     
==========================================
  Files          72       72              
  Lines        5178     5176       -2     
  Branches      895      895              
==========================================
- Hits         4977     4975       -2     
  Misses        119      119              
  Partials       82       82              
Flag Coverage Δ
centos-linux-7 91.63% <ø> (-0.01%) ⬇️
centos-linux-8 92.49% <ø> (-0.01%) ⬇️
centos-linux-9 92.61% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danmyway danmyway added tests/skip This PR does not require integration tests to be run. kind/refactor labels Dec 6, 2024
@has-bot
Copy link
Member

has-bot commented Dec 6, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

@danmyway
Copy link
Member Author

danmyway commented Dec 6, 2024

/packit test --labels sanity

@danmyway danmyway changed the title Remove debug messages when comparing c2r versions [RHELC-1682] Remove debug messages when comparing c2r versions Dec 6, 2024
@Venefilyn
Copy link
Member

Venefilyn commented Dec 6, 2024

LGTM, merge whenever and update Jira

@danmyway danmyway merged commit 940e048 into oamg:main Dec 6, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants