Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twilio credentials update #4251

Closed
wants to merge 7 commits into from
Closed

Twilio credentials update #4251

wants to merge 7 commits into from

Conversation

norkans7
Copy link

@norkans7 norkans7 commented Jan 18, 2023 •
edited
Loading

Addresses #4227

@codecov
Copy link

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Merging #4251 (c5947b6) into main (e381b92) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #4251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          442       443    +1     
  Lines        25886     25978   +92     
=========================================
+ Hits         25886     25978   +92
Impacted Files Coverage Δ
temba/channels/types/twilio/type.py 100.00% <100.00%> (ø)
...ba/channels/types/twilio_messaging_service/type.py 100.00% <100.00%> (ø)
temba/channels/types/twilio_whatsapp/type.py 100.00% <100.00%> (ø)
temba/utils/twilio/views.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@norkans7 norkans7 marked this pull request as ready for review January 19, 2023 16:53
@rowanseymour rowanseymour changed the title WIP Twilio credentials update Twilio credentials update Jan 19, 2023
@rowanseymour rowanseymour mentioned this pull request Jan 24, 2023
Open
@rowanseymour
Copy link
Member

Closing in favor of #4275

@rowanseymour rowanseymour deleted the twilio-keys-update branch January 31, 2023 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericnewcomer ericnewcomer Awaiting requested review from ericnewcomer

@rowanseymour rowanseymour Awaiting requested review from rowanseymour

@susanm74 susanm74 Awaiting requested review from susanm74

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norkans7 @rowanseymour