Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: don't load bundles with opt items, add api for loading them #61

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Jul 11, 2024

Closes #59

@mrcjkb mrcjkb requested a review from vhyrro as a code owner July 11, 2024 16:54
lua/rocks-config/internal.lua Outdated Show resolved Hide resolved
@mrcjkb mrcjkb marked this pull request as draft July 28, 2024 14:01
@mrcjkb mrcjkb changed the title feat!: don't load bundles with only opt items, add load_bundle api feat!: don't load bundles with opt items, add load_bundle api Jul 28, 2024
@mrcjkb mrcjkb marked this pull request as ready for review July 28, 2024 14:24
@mrcjkb mrcjkb changed the title feat!: don't load bundles with opt items, add load_bundle api feat!: don't load bundles with opt items, add api for loading them Jul 29, 2024
Copy link
Contributor

@vhyrro vhyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find any issues by looking at the code. Looks good to me :)

@mrcjkb mrcjkb merged commit 41c08bf into main Sep 16, 2024
5 checks passed
@mrcjkb mrcjkb deleted the opt-bundles branch September 16, 2024 11:17
@mrcjkb mrcjkb mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Api for manually loading bundles
2 participants