-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SAPI5 & MSSP voices use WavePlayer (WASAPI) #17592
Open
gexgd0419
wants to merge
10
commits into
nvaccess:master
Choose a base branch
from
gexgd0419:sapi5-wasapi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
92f07ef
Make SAPI5 voices use WavePlayer
gexgd0419 20f754d
Pre-commit auto-fix
pre-commit-ci[bot] 93ebd88
Use high-level implementation when implementing COM interfaces
gexgd0419 2f7c14e
Add changelog entry in Changes
gexgd0419 c55bada
Add type hints and docstrings
gexgd0419 266e333
Change parameter names of RemoteWrite back to match the interface def…
gexgd0419 3d458ce
Remove SPAudioState
gexgd0419 50627b4
Add API breaking change entries
gexgd0419 efb8604
Merge branch 'master' into sapi5-wasapi
gexgd0419 ade6b8e
Add type hint for pv
gexgd0419 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly spoken, this is breaking backwards compatibility. That said, I think it is safe to mark this as such in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the implementation of
SapiSink
should be internal and not considered as part of the public API, so it shouldn't be a breaking change. I couldn't find references toSapiSink
outsidesapi5.py
in NVDA's code.Also, the function parameter list of
StartStream
,Bookmark
andEndStream
is mostly the same.But it should be noted that event notification can be sent on any thread, instead of always on the main thread, which is also the reason why I chose to use
ISpNotifySink
directly.Do I need to mention this in the "Changes for Developers" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, any removed public code (not prefixed with
_
), and other breaking API changes must be listed in API breaking changes under changes for developers. It doesn't seem like the API forSapiSink
(e.g functions you listed) has changed, can you confirm?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the
if synth is None
checks in them, because the events are now dispatched inISpNotifySink_Notify
and the check has been done there. The usage ofSapiSink
is also changed, although the parameter lists of those functions are the same.