Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBUI-785: nuxeo-document-tree icon needs to be focusable lts 2023 #2414

Open
wants to merge 1 commit into
base: maintenance-3.1.x
Choose a base branch
from
Open

WEBUI-785: nuxeo-document-tree icon needs to be focusable lts 2023 #2414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion elements/nuxeo-document-tree/nuxeo-document-tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ Polymer({
cursor: pointer;
}

[toggle]:focus {
outline: 2px solid black;
outline-offset: 0.2px;
border-radius: 3px;
box-shadow: 0 0 3px black;
background-color: rgba(0, 0, 0, 0);
}

.parents {
line-height: 1.5em;
}
Expand Down Expand Up @@ -191,7 +199,16 @@ Polymer({
<div role="treeitem" aria-expanded="[[opened]]">
<template class="flex" is="dom-if" if="[[!isLeaf]]">
<paper-spinner active$="[[loading]]" aria-hidden="true"></paper-spinner>
<iron-icon icon="[[_expandIcon(opened)]]" toggle hidden$="[[loading]]" aria-hidden="true"></iron-icon>
<iron-icon
icon="[[_expandIcon(opened)]]"
toggle
hidden$="[[loading]]"
tabindex="0"
role="button"
aria-hidden="false"
aria-label="Toggle expand/collapse"
on-keydown="_handleKeydown"
></iron-icon>
<template is="dom-if" if="[[loading]]">
<span class="loaddata" aria-live="polite">[[_loading(loading)]]</span>
</template>
Expand Down Expand Up @@ -306,6 +323,27 @@ Polymer({
}
},

_handleKeydown(event) {
const icon = event.target;
const treeItem = icon.closest('[role="treeitem"]');
if (event.key === 'Enter' || event.key === ' ' || event.key === 'ArrowDown') {
// Toggle aria-expanded state
const expanded = treeItem.getAttribute('aria-expanded') === 'true';
treeItem.setAttribute('aria-expanded', !expanded);
// Manually trigger the click event on the chevron icon
icon.click();
// Dispatch custom event for external handling
this.dispatchEvent(
new CustomEvent('tree-node-toggled', {
detail: { expanded: !expanded, target: treeItem },
bubbles: true,
composed: true,
}),
);
event.preventDefault(); // Prevent default scrolling or focus behavior
}
},

_currentDocumentChanged() {
const doc = this.currentDocument;
if (doc && doc.path && doc.path.startsWith(this.rootDocPath)) {
Expand Down
Loading