Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SM2.0 (NrvO).cps #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calebmcmains
Copy link

Updated .cps to give an option to export with a "header" that matches the one output by the Luban Software if used it to create a CNC process. There is data in the Snapmaker header that they use in the "Workspace" where you send to to your machine over wifi.

I also added the ability to access "Machining Time" and displaying it anyway you'd like with a conversion function. I just thought it would be nice to know how long the machining is going to take.

Finally, I added a way to track "previousFeedRate" because according to the Snapmaker Reference Docs there is no need to write the the federate on every line so instead it only writes it when it changes. <- this implementation does need a second set of eyes incase something was missed and a feed rate isn't being printed correctly which could cause something to happen. This is a "clean code" implementation not a necessary one so it could be omitted entirely.

Updated .cps to give an option to export with a "header" that matches the one output by the Luban Software if used it to create a CNC process. There is data in the Snapmaker header that they use in the "Workspace" where you send to to your machine over wifi. 

I also added the ability to access "Machining Time" and displaying it anyway you'd like with a conversion function. I just thought it would be nice to know how long the machining is going to take.

Finally, I added a way to track "previousFeedRate" because according to the Snapmaker Reference Docs there is no need to write the the federate on every line so instead it only writes it when it changes. <- this implementation does need a second set of eyes incase something was missed and a feed rate isn't being printed correctly which could cause something to happen. This is  a "clean code" implementation not a necessary one so it could be omitted entirely.
@calebmcmains
Copy link
Author

I opened an issue in your repository and then decided that I would attempt to implement the solution to it. I must say I am very impressed with what you have created! Thank you for your time and diligence especially in the details of how got to where it is. I was able to read your code and the resources you found most helpful to create some additions that may be worth adding. I hope my contributions are helpful! Looking forward to hearing from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant