feat: move to isoparser 1.9.X #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that because of the burden of maintaining two different versions of this, we might end up publishing a fork |
numandev1
approved these changes
Sep 11, 2024
|
@Titozzz looking good to me, if you are done then I can merge it and release new version |
|
That'd work for me |
|
Do you want me to clean up old code that would not be used anymore? |
|
@Titozzz it would be good if you cleaned up the code, I will merge and release it, thanks a lot for this PR |
|
Hey, I'm unsure why CI is grumpy, but fixing it in that PR might create a lot of noise, as I'm pretty sure the issues from CI are not caused by these changes. All green on my side and good to merge. |
|
I think, CI has outdated, going to merge and release it |
|
released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is a draft supporting the newest version of isoparser.
Summary
One of our dependency (intercom) again bumped their version of isoparser and both could not be used at the same time.
This PR updates to latest to allow use using both libraries at the same time.
However, this change is not backward compatible nor I know how I would achieve something that'd work on both versions as I did with 1.0 & 1.1
Feel free to use / merge / modify this if you want.
We'll probably use patch-package on our side but I wanted to share this work.
Changelog
[REFACTOR][DEPENDENCY]: update isoparser to version 1.9+
Test Plan
Used the example app to make sure everything was OK.