SoftwareSerial dependency removed. Upgraded to support C++11 #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a Stream you can support both hardware and software serial while having the same functionality. By the way, the initialization of the serial interface should be handled by the user himself which is not a complicated task and offers more flexibility. Also, the Arduino library manager conflicts with adding the library due to this dependency, at least for me 🙂.
After brute-forcing the library to my Arduino IDE, I received some "type mismatch" errors regarding casting integer values to enum ones. It seems that You were using an older version of Arduino C++ compiler which allows such a thing but with more recent versions such a cast should be done explicitly through a static_cast function. I also handled this issue in my Fork.
I am planning to create a new branch, continue the development of the library, and test it on my setup which consists of an ESP32-based LILYGO T-Display and a SIM900A Mini V3.8.2. module. I will use software serial in my project.