Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a match when completing commands #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DarwinAwardWinner
Copy link
Contributor

This sets the require-match argument to t when calling ido-completing-read, and it also switches to using ido-completing-read+, since standard ido doesn't handle require-match being non-nil.

A second commit also removes an obsolete fix for a problem that should no longer exist.

This sets the "require-match" argument to t when calling
ido-completing-read, and it also switches to using
ido-completing-read+ [1], since standard ido doesn't handle
"require-match" being non-nil.

[1] https://github.com/DarwinAwardWinner/ido-ubiquitous#ido-completing-read
ido-ubiquitous no longer has any effect on completions that are not
initiated through its own functions, so this fix is no longer
necessary.
@DarwinAwardWinner
Copy link
Contributor Author

Oh, and for an example where this makes a difference, enable smex and try M-x execute-ex C-j. With current master it says execute-extended-command: ‘execute-ex’ is not a valid command name. With this patch, it completes to the longest unambiguous substring instead.

It was already declared in the Cask file, but it needs to be in both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant