Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: add eval ts input #56394

Merged
merged 1 commit into from
Jan 3, 2025
Merged

worker: add eval ts input #56394

merged 1 commit into from
Jan 3, 2025
+93 −1

Conversation

marco-ippolito
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 29, 2024
@marco-ippolito marco-ippolito added worker Issues and PRs related to Worker support. strip-types Issues or PRs related to strip-types support labels Dec 29, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.52%. Comparing base (67b647e) to head (ce3dc7e).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/main/worker_thread.js 84.61% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56394      +/-   ##
==========================================
- Coverage   88.54%   88.52%   -0.02%     
==========================================
  Files         657      657              
  Lines      190689   190763      +74     
  Branches    36602    36616      +14     
==========================================
+ Hits       168844   168876      +32     
- Misses      15029    15053      +24     
- Partials     6816     6834      +18
Files with missing lines Coverage Δ
lib/internal/main/worker_thread.js 94.48% <84.61%> (-0.99%) ⬇️

... and 37 files with indirect coverage changes

@marco-ippolito marco-ippolito added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. semver-minor PRs that contain new features and should be released in the next minor version. labels Dec 30, 2024
@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64279/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64288/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 3, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56394
✔  Done loading data for nodejs/node/pull/56394
----------------------------------- PR info ------------------------------------
Title      worker: add eval ts input (#56394)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     marco-ippolito:eval-ts-in-workers -> nodejs:main
Labels     semver-minor, author ready, worker, needs-ci, dont-land-on-v18.x, dont-land-on-v20.x, strip-types
Commits    1
 - worker: add eval ts input
Committers 1
 - Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/56394
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56394
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 29 Dec 2024 12:16:50 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56394#pullrequestreview-2525995852
   ✘  This PR needs to wait 51 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-01-02T06:51:22Z: https://ci.nodejs.org/job/node-test-pull-request/64288/
- Querying data for job/node-test-pull-request/64288/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12594931797

@marco-ippolito marco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 3, 2025
ShogunPanda
ShogunPanda approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2025
@nodejs-github-bot nodejs-github-bot merged commit 76b80b1 into nodejs:main Jan 3, 2025
85 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 76b80b1

marco-ippolito added a commit that referenced this pull request Jan 3, 2025
@marco-ippolito
worker: add eval ts input
8b20cc2 
PR-URL: #56394
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@github-actions github-actions bot mentioned this pull request Jan 3, 2025
Open
nodejs-github-bot added a commit that referenced this pull request Jan 3, 2025
@nodejs-github-bot
2025-01-07, Version 23.6.0 (Current)
3062e40 
Notable changes:

lib:
  * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) #56359
module:
  * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) #56350
process:
  * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) #56400
worker:
  * (SEMVER-MINOR) add eval ts input (Marco Ippolito) #56394

PR-URL: #56450
marco-ippolito pushed a commit that referenced this pull request Jan 3, 2025
@nodejs-github-bot @marco-ippolito
2025-01-07, Version 23.6.0 (Current)
9fa6aeb 
Notable changes:

lib:
  * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) #56359
module:
  * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) #56350
process:
  * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) #56400
worker:
  * (SEMVER-MINOR) add eval ts input (Marco Ippolito) #56394

PR-URL: #56450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarchini pmarchini pmarchini approved these changes

@jasnell jasnell jasnell approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. strip-types Issues or PRs related to strip-types support worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marco-ippolito @nodejs-github-bot @ShogunPanda @jasnell @pmarchini