fix: missing ref flag when writing type ref #143

gxkl · 2024-07-29T15:21:41Z

v2 版本，修复写类型 ref 时，缺失标志位问题

coderabbitai · 2024-07-29T15:21:47Z

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2024-07-29T15:22:11Z

commit: 8f99ef5

npm i https://pkg.pr.new/node-modules/hessian.js/hessian.js-1@143

Open in Stackblitz •

codecov · 2024-07-29T15:25:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (7c14b64) to head (8f99ef5).

Additional details and impacted files

@@            Coverage Diff             @@
##              1.x     #143      +/-   ##
==========================================
+ Coverage   94.67%   95.28%   +0.61%     
==========================================
  Files           9        9              
  Lines        1145     1146       +1     
  Branches      203      203              
==========================================
+ Hits         1084     1092       +8     
+ Misses         61       54       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

killagu · 2024-08-01T12:46:10Z

killagu

LGTM

fengmk2 · 2024-08-05T05:41:50Z

lib/v2/encoder.js

@@ -416,6 +416,7 @@ proto.writeType = function (type) {
  var ref = this._typeRefs.indexOf(type);
  if (ref >= 0) {
    var TYPE_REF = 0x75; // 'u'
+    this.byteBuffer.put(TYPE_REF);


https://github.com/node-modules/hessian.js @gxkl master 分支是否也有一样的 bug？

https://github.com/node-modules/hessian.js/blob/master/lib/v2/decoder.js#L493
master 上的实现是 default 为 ref，应该没有这个问题

fix: missing ref flag when writing type ref

8f99ef5

gxkl requested review from killagu and fengmk2 July 29, 2024 15:21

killagu approved these changes Aug 1, 2024

View reviewed changes

gxkl merged commit 1de56e9 into 1.x Aug 1, 2024
23 checks passed

gxkl deleted the fix/type-ref branch August 1, 2024 12:51

fengmk2 reviewed Aug 5, 2024

View reviewed changes

fengmk2 added the bug label Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: missing ref flag when writing type ref #143

fix: missing ref flag when writing type ref #143

gxkl commented Jul 29, 2024

coderabbitai bot commented Jul 29, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

pkg-pr-new bot commented Jul 29, 2024

codecov bot commented Jul 29, 2024

killagu commented Aug 1, 2024

killagu left a comment

fengmk2 Aug 5, 2024

gxkl Aug 5, 2024

fix: missing ref flag when writing type ref #143

fix: missing ref flag when writing type ref #143

Conversation

gxkl commented Jul 29, 2024

coderabbitai bot commented Jul 29, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

pkg-pr-new bot commented Jul 29, 2024

codecov bot commented Jul 29, 2024

Codecov Report

killagu commented Aug 1, 2024

killagu left a comment

Choose a reason for hiding this comment

fengmk2 Aug 5, 2024

Choose a reason for hiding this comment

gxkl Aug 5, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Jul 29, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)