Add compiler support for offloading matmul ops to custom dispatch plugin. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably needs a rebase. |
monorimet
force-pushed
the
ean-accel-2
branch
from
63957ca to
16d176a
Compare
|
Auto-rebase 🫠 |
| linalg::MatmulOp matmulOp) { | ||
| assert(!getLoweringConfig(matmulOp) && "expected lowering_config is not set"); | ||
| SmallVector<int64_t> tileSizes; | ||
| tileSizes.push_back(1); |
There was a problem hiding this comment.
Why do you need {1} here? Are you actually tiling it by 1?
| auto targetAttr = IREE::HAL::ExecutableTargetAttr::lookup(op); | ||
| auto fn = getFnNameAndDefAttrs("accel_matmul_f32", rewriter, targetAttr); | ||
| auto genericMicroKernelOp = rewriter.create<IREE::Codegen::UKernelGenericOp>( | ||
| loc, outType, fn.name, ValueRange{lhs, rhs}, out, ValueRange{m, n, k}, |
There was a problem hiding this comment.
Are you sure the plugin is taking {m, n, k} last I saw it was {m, k, n}. Just need to be consistent.
| IREE::HAL::ExecutableTargetAttr targetAttr) { | ||
| FnNameAndDefAttrs result; | ||
| result.name = ukernelName; | ||
| result.defAttrs.emplace_back( |
There was a problem hiding this comment.
Only add these if the plugin needs it. If it doesnt, just lesser things to deal with.
powderluv
force-pushed
the
shark
branch
6 times, most recently
from
0974a63 to
f2db766
Compare
powderluv
force-pushed
the
shark
branch
5 times, most recently
from
80b79ee to
cc560af
Compare
powderluv
force-pushed
the
shark
branch
6 times, most recently
from
4b3b84c to
acc15de
Compare
powderluv
force-pushed
the
shark
branch
12 times, most recently
from
b1a76d3 to
70bfff7
Compare
powderluv
force-pushed
the
shark
branch
6 times, most recently
from
ddfa659 to
62bc699
Compare
powderluv
force-pushed
the
shark
branch
4 times, most recently
from
fc9ac3f to
af49be0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lit test and fix build.
Fixes to LowerToAccelUKernelPass
Tweaks to LowerToAccelUKernelsPass.
Add AccelMatmulExpert pass pipeline
Apply clang-format to new C++ files. (#3)
Use parameter struct calling convention
Tweaks to KernelDispatch and AccelMatmulExpert pipeline