Skip to content

Commit

Permalink
[Codegen][GPU] Move PackToIntrinsics after workgroup tiling (iree-org…
Browse files Browse the repository at this point in the history
…#17950)

Doing `PackToIntrinsics` before workgroup tiling is putting lower level
lowering details too early in the pipeline, especially given that
padding needs to happen at the workgroup level, not before that.

There is nothing to test for here, the generated IR remains the same.
  • Loading branch information
qedawkins authored Jul 19, 2024
1 parent 6e23ed1 commit 6e9d4cf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions compiler/src/iree/compiler/Codegen/LLVMGPU/Passes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -289,13 +289,12 @@ void addGPUVectorizationPassPipeline(OpPassManager &funcPassManager) {
//===---------------------------------------------------------------------===//

void addGPUTileAndFusePassPipeline(OpPassManager &funcPassManager) {
tileAndDistributeToWorkgroup(funcPassManager);

// Step 1. Promote matmul operands and pack to intrinsic shapes.
funcPassManager.addPass(createGPUPromoteMatmulOperandsPass());
funcPassManager.addPass(IREE::GPU::createPackToIntrinsicsPass());

tileAndDistributeToWorkgroup(funcPassManager);

// Step 2. Tile and fuse tileable ops to reduction loops.
{
GPUApplyTilingLevelPassOptions options;
Expand Down

0 comments on commit 6e9d4cf

Please sign in to comment.