Skip to content

Commit

Permalink
[hal][hip] Use stream command buffer in parameter initialization (ire…
Browse files Browse the repository at this point in the history
…e-org#17960)

This makes the behavior the same as when invoking from the command line
tools. Also HIP graph still needs improvements to be efficient.
  • Loading branch information
antiagainst authored Jul 19, 2024
1 parent 8b44f61 commit 57361bc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions runtime/src/iree/hal/drivers/hip/hip_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "iree/hal/drivers/hip/event_semaphore.h"
#include "iree/hal/drivers/hip/graph_command_buffer.h"
#include "iree/hal/drivers/hip/hip_allocator.h"
#include "iree/hal/drivers/hip/hip_buffer.h"
#include "iree/hal/drivers/hip/memory_pools.h"
#include "iree/hal/drivers/hip/nop_executable_cache.h"
#include "iree/hal/drivers/hip/pending_queue_actions.h"
Expand Down Expand Up @@ -108,7 +107,7 @@ IREE_API_EXPORT void iree_hal_hip_device_params_initialize(
out_params->arena_block_size = 32 * 1024;
out_params->event_pool_capacity = 32;
out_params->queue_count = 1;
out_params->command_buffer_mode = IREE_HAL_HIP_COMMAND_BUFFER_MODE_GRAPH;
out_params->command_buffer_mode = IREE_HAL_HIP_COMMAND_BUFFER_MODE_STREAM;
out_params->stream_tracing = false;
out_params->async_allocations = true;
out_params->allow_inline_execution = false;
Expand Down

0 comments on commit 57361bc

Please sign in to comment.