Skip to content

Commit

Permalink
[hip] Don't join the status in dispatch_thread. (iree-org#19583)
Browse files Browse the repository at this point in the history
If the status was an error status that we are passing in, then it will
be passed back to us. It is incorrect to join it.

Signed-off-by: Andrew Woloszyn <andrew.woloszyn@gmail.com>
  • Loading branch information
AWoloszyn authored Jan 6, 2025
1 parent cdf24b9 commit 0820f10
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions runtime/src/iree/hal/drivers/hip/dispatch_thread.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ static int iree_hal_hip_dispatch_thread_main(void* param) {
iree_hal_hip_dispatch_queue_pop_front(&thread->queue, 1);
iree_slim_mutex_unlock(&thread->mutex);

status = iree_status_join(status,
dispatch.dispatch(dispatch.user_data, status));
// The status passed will be joined and returned.
status = dispatch.dispatch(dispatch.user_data, status);
iree_slim_mutex_lock(&thread->mutex);
if (!iree_status_is_ok(status)) {
// We don't join here as the failure status was already
Expand Down

0 comments on commit 0820f10

Please sign in to comment.