Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Windows ARM64 support #92

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: Add Windows ARM64 support #92

merged 1 commit into from
Dec 6, 2024

Conversation

njzjz
Copy link
Owner

@njzjz njzjz commented Dec 6, 2024

Fix #87.

Add support for Windows ARM64 cross-compilation.

  • CMakeLists.txt
  • Add a new elseif block for WIN32 AND CMAKE_SYSTEM_PROCESSOR STREQUAL "ARM64" to handle Windows ARM64 builds.
  • Set the BUILD_COMMAND to ./vcbuild arm64 for Windows ARM64 builds.
  • Set the INSTALL_COMMAND to an empty string for Windows ARM64 builds.
  • Add an install command to copy the node.exe file to the appropriate destination for Windows ARM64 builds.
  • Add an install command to copy the npm directory to the appropriate destination for Windows ARM64 builds.
  • .github/workflows/build_wheel.yml
  • Add a new matrix entry for Windows ARM64 builds with os: windows-latest and platform_id: win_arm64.
  • Add a condition to the ilammy/setup-nasm@v1 step to include matrix.platform_id == 'win_arm64'.

For more details, open the Copilot Workspace
session
.


Fix #87.

Add support for Windows ARM64 cross-compilation.

* **CMakeLists.txt**
- Add a new `elseif` block for `WIN32 AND CMAKE_SYSTEM_PROCESSOR
STREQUAL "ARM64"` to handle Windows ARM64 builds.
- Set the `BUILD_COMMAND` to `./vcbuild arm64` for Windows ARM64 builds.
- Set the `INSTALL_COMMAND` to an empty string for Windows ARM64 builds.
- Add an `install` command to copy the `node.exe` file to the
appropriate destination for Windows ARM64 builds.
- Add an `install` command to copy the `npm` directory to the
appropriate destination for Windows ARM64 builds.

* **.github/workflows/build_wheel.yml**
- Add a new matrix entry for Windows ARM64 builds with `os:
windows-latest` and `platform_id: win_arm64`.
- Add a condition to the `ilammy/setup-nasm@v1` step to include
`matrix.platform_id == 'win_arm64'`.

---

For more details, open the [Copilot Workspace
session](https://copilot-workspace.githubnext.com/njzjz/nodejs-wheel/pull/91?shareId=127f29b4-7a5a-4aeb-882f-a853583447a7).

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@njzjz njzjz enabled auto-merge (squash) December 6, 2024 04:52
@njzjz njzjz merged commit ea67c9a into master Dec 6, 2024
11 checks passed
@njzjz njzjz deleted the winarm64 branch December 6, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows arm64 binaries
1 participant