pull in upstream changes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindly ignore vim backup-files
Really fix check mode.
The iptables wrapper script does not fail on errors via `set -e` or similar, because failing in the middle of the run could leave the system is a bad a state. The iptables commands do write to stderr, however, providing informative error messages that are mostly ignored by the role. Similar to how we're already detecting "unknown option" and failing when found, we'll also fail if iptables reports "Table does not exist", which is definitely something an administrator will want to know about, and certainly constitutes a failure mode. Closes #24.
…rted Fails if target table does not exist
add ipset-persistent to fix security bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly just need firewall_v4_flush_rules to prevent nexcess.firewall from clobbering some docker controlled chains