feat: add possibility for unordered ica channels

neutron-org · Aug 7, 2024 · b0d127f · b0d127f
1 parent 8170243
commit b0d127f
Show file tree

Hide file tree

Showing 4 changed files with 97 additions and 62 deletions.
diff --git a/proto/neutron/interchaintxs/v1/tx.proto b/proto/neutron/interchaintxs/v1/tx.proto
@@ -11,6 +11,7 @@ import "google/api/http.proto";
 import "google/protobuf/any.proto";
 import "neutron/feerefunder/fee.proto";
 import "neutron/interchaintxs/v1/params.proto";
+import "ibc/core/channel/v1/channel.proto";
 
 option go_package = "github.com/neutron-org/neutron/v4/x/interchaintxs/types";
 
@@ -36,6 +37,7 @@ message MsgRegisterInterchainAccount {
     (gogoproto.nullable) = false,
     (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"
   ];
+  ibc.core.channel.v1.Order ordering      = 5;
 }
 
 // MsgRegisterInterchainAccountResponse is the response type for

diff --git a/x/dex/types/limit_order_tranche_user.pb.go b/x/dex/types/limit_order_tranche_user.pb.go
diff --git a/x/interchaintxs/keeper/msg_server.go b/x/interchaintxs/keeper/msg_server.go
@@ -66,7 +66,7 @@ func (k Keeper) RegisterInterchainAccount(goCtx context.Context, msg *ictxtypes.
 		Owner:        icaOwner,
 		ConnectionId: msg.ConnectionId,
 		Version:      "", // FIXME: empty version string doesn't look good
-		Ordering:     channeltypes.ORDERED,
+		Ordering:     msg.ChannelOrdering,
 	})
 	if err != nil {
 		k.Logger(ctx).Debug("RegisterInterchainAccount: failed to RegisterInterchainAccount:", "error", err, "owner", icaOwner, "msg", &msg)

diff --git a/x/interchaintxs/types/tx.pb.go b/x/interchaintxs/types/tx.pb.go