Feat: Cosmos SDK 47 #109
Merged
Feat: Cosmos SDK 47 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add ResubmitSchedule neutron msg #ntrn-84
Rework governance/ update admin-module NTRN-70 (sdk-47)
added register_fee field for register interchain account msg
Update our tokenfactory to the latest version NTRN-93
[NTRN-163] add dex stargate helpers
swelf19
previously approved these changes
Dec 18, 2023
| pub fn submit_create_denom(subdenom: impl Into<String>) -> Self { | ||
| NeutronMsg::CreateDenom { | ||
| subdenom: subdenom.into(), | ||
| } | ||
| } | ||
|
|
||
| // Basic helper to define change of admin for a token passed to TokenFactory module: |
There was a problem hiding this comment.
Does not look clear, what exactly we pass to TokenFactory module. Did you miss the message word?
And the same with alomost every "Basic helper to"
ratik
reviewed
Dec 19, 2023
ratik
reviewed
Dec 19, 2023
ratik
reviewed
Dec 19, 2023
ratik
requested changes
Dec 19, 2023
ratik
previously approved these changes
Dec 20, 2023
sotnikov-s
approved these changes
Dec 20, 2023
ratik
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes neutron-sdk compatible with Neutron V2 release: