Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Whitelist tokenfactory hooks (disable tests only) #316

Closed
wants to merge 3 commits into from

Conversation

jcompagni10
Copy link
Contributor

@jcompagni10 jcompagni10 commented Jun 21, 2024

Changes for: neutron-org/neutron#587

Changes:

  • Disable setBeforeSendHook tests. Given the operation overhead of whitelisting, it is unlikely the contracts will be setting BeforeSendHooks.
  • Fix parameters used in tests. Fixes to validation on the neutron side have caused the old parameters to fail

@jcompagni10
Copy link
Contributor Author

expect(queryBlock.block.received).toEqual(true);
});
// TEMP: remove tests for before send hook
// test('create denom, set before send hook', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need these tests, the only difference - we should create hooks via proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants