feat: whitelist tf hooks #314
Conversation
|
the rest LGTM |
| newTokenDenom, | ||
| contractAddress, | ||
| ); | ||
| expect(res.code).not.toEqual(0); // set hook fails |
There was a problem hiding this comment.
would be more accurate to check that the exact error is returned, not that just something went wrong
| newTokenDenom, | ||
| contractAddress, | ||
| ); | ||
| expect(res2.code).toEqual(14); // "beforeSendHook is not whitelisted" |
There was a problem hiding this comment.
it's good enough to check the code, but just FYI for the future: a more convenient IMO way to check errors is by the error message e.g. like here (or actually in many other places in our tests)
neutron-integration-tests/src/testcases/run_in_band/tge.auction.test.ts
Lines 1977 to 1988 in 601f061
There was a problem hiding this comment.
could be mistaken but the way msgSetBeforeSendHook is called I can't use rejects
| let timelockedProp = await subdaoMember1.supportAndExecuteProposal( | ||
| proposalId, | ||
| ); | ||
| await waitSeconds(10); | ||
| await subdaoMember1.executeTimelockedProposal(proposalId); | ||
| timelockedProp = await subDao.getTimelockedProposal(proposalId); | ||
| expect(timelockedProp.id).toEqual(proposalId); | ||
| expect(timelockedProp.status).toEqual('executed'); |
There was a problem hiding this comment.
didn't this (speeded up?) approach work? I can see that you added it and then removed in the latest commits
for neutron-org/neutron#587 -- Allow chain manager dao to whitelist tokenfactory hooks
Related PRs
neutron-org/neutron-dao#107
neutron-org/neutron-sdk#150
neutron-org/neutronjsplus#43
Integration Test Run
https://github.com/neutron-org/neutron-tests/actions/runs/9765613806