Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit fixes: remove interchain_tx_in_progress from state #4

Merged
merged 2 commits into from
Nov 20, 2023
Merged

audit fixes: remove interchain_tx_in_progress from state #4

merged 2 commits into from
Nov 20, 2023

Conversation

NeverHappened
Copy link
Collaborator

@NeverHappened NeverHappened commented Nov 14, 2023 •
edited
Loading

What pr fixes:

  • In initialisation add amount field that will be used in FundCommunityPool execution instead of an argument to avoid spam with invalid argument
  • Removed interchain_tx_in_progress since it does not make stages after deletion of stages and also can make contract unusable forever

@NeverHappened NeverHappened self-assigned this Nov 14, 2023
sotnikov-s
sotnikov-s reviewed Nov 17, 2023
View reviewed changes
Copy link

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please attach something describing the task, e.g. audit notes. I have no idea what is this PR about to fix/improve and why

@pr0n00gler pr0n00gler merged commit 76c77e9 into main Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotnikov-s sotnikov-s sotnikov-s approved these changes

@pr0n00gler pr0n00gler pr0n00gler approved these changes

Assignees

@NeverHappened NeverHappened

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeverHappened @pr0n00gler @sotnikov-s