Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for get_transactions and get_cells RPC #4210

Merged

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Add rpc doc for get_transactions and get_cells to clarify their pagination style.
When the number of returned objects is less than the requested limit, it indicates that it's the last page.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec added the t:doc Type: Documentation label Oct 30, 2023
@eval-exec eval-exec requested a review from a team as a code owner October 30, 2023 14:25
@eval-exec eval-exec changed the title Add doc for get_transactions and get_cells pagination Add doc for get_transactions and get_cells RPC Oct 30, 2023
rpc/src/module/indexer.rs Outdated Show resolved Hide resolved
@eval-exec eval-exec force-pushed the exec/get-cells-rpc-doc branch from 0ee16e6 to cdf5720 Compare October 31, 2023 02:20
Co-authored-by: ian <me@iany.me>
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/get-cells-rpc-doc branch from cdf5720 to 185a406 Compare October 31, 2023 02:20
@zhangsoledad zhangsoledad added this pull request to the merge queue Nov 1, 2023
Merged via the queue into nervosnetwork:develop with commit a888c13 Nov 1, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:doc Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants