persistence softfork cache #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/softfork-cache
branch
from
5765818 to
cb12d58
Compare
zhangsoledad
force-pushed
the
zhangsoledad/softfork-cache
branch
3 times, most recently
from
b93adac to
9582cd4
Compare
zhangsoledad
force-pushed
the
zhangsoledad/softfork-cache
branch
from
9582cd4 to
f5095d8
Compare
zhangsoledad
force-pushed
the
zhangsoledad/softfork-cache
branch
from
f5095d8 to
f584807
Compare
zhangsoledad
force-pushed
the
zhangsoledad/softfork-cache
branch
from
3fa9bdb to
ba5bc01
Compare
eval-exec
reviewed
Nov 2, 2023
util/types/src/core/mod.rs
Outdated
| pub use advanced_builders::{BlockBuilder, HeaderBuilder, TransactionBuilder}; | ||
| pub use blockchain::DepType; | ||
| pub use extras::{BlockExt, EpochExt, EpochNumberWithFraction, TransactionInfo}; | ||
| pub use fee_rate::FeeRate; | ||
| use once_cell::sync::OnceCell; |
There was a problem hiding this comment.
OnceCell have been merged into rust's std library: https://doc.rust-lang.org/std/cell/struct.OnceCell.html
There was a problem hiding this comment.
The once_cell in std is still a bit different from the crate we're using now, and the equivalent would be https://doc.rust-lang.org/std/sync/struct.OnceLock.html, which we can decide to replace later.
eval-exec
approved these changes
Nov 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In RFC0043 we introduced the signal mechanism to implement softfork-activation, for each softfork deployment its state needs to be accumulated statistics, the current implementation is to use a memory cache to store the state, resulting in each reboot, the state of the deployment needs to be regenerated. when in the case of large amounts of data, the reboot will be lagged for some time.
What is changed and how it works?
Introduces a persistent mmap cache so that the state doesn't need to be recalculated each time it is restarted
The persistence path is stored in DATA_DIR/softfork/<deployment>/<cache file> format.
after
Related changes
owner/repo:Check List
Tests
Side effects
Release note