Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: tuning rocksdb bloom filter #4191

Merged
merged 2 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 42 additions & 8 deletions db/src/db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ use rocksdb::ops::{
Put, SetOptions, WriteOps,
};
use rocksdb::{
ffi, ColumnFamily, ColumnFamilyDescriptor, DBPinnableSlice, FullOptions, IteratorMode,
OptimisticTransactionDB, OptimisticTransactionOptions, Options, WriteBatch, WriteOptions,
ffi, BlockBasedIndexType, BlockBasedOptions, Cache, ColumnFamily, ColumnFamilyDescriptor,
DBPinnableSlice, FullOptions, IteratorMode, OptimisticTransactionDB,
OptimisticTransactionOptions, Options, SliceTransform, WriteBatch, WriteOptions,
};
use std::path::Path;
use std::sync::Arc;
Expand All @@ -25,20 +26,28 @@ pub struct RocksDB {
pub(crate) inner: Arc<OptimisticTransactionDB>,
}

const DEFAULT_CACHE_SIZE: usize = 128 << 20;
const DEFAULT_CACHE_SIZE: usize = 256 << 20;
const DEFAULT_CACHE_ENTRY_CHARGE_SIZE: usize = 4096;

impl RocksDB {
pub(crate) fn open_with_check(config: &DBConfig, columns: u32) -> Result<Self> {
let cf_names: Vec<_> = (0..columns).map(|c| c.to_string()).collect();
let mut cache = None;

let (mut opts, cf_descriptors) = if let Some(ref file) = config.options_file {
let cache_size = match config.cache_size {
let (mut opts, mut cf_descriptors) = if let Some(ref file) = config.options_file {
cache = match config.cache_size {
Some(0) => None,
Some(size) => Some(size),
None => Some(DEFAULT_CACHE_SIZE),
Some(size) => Some(Cache::new_hyper_clock_cache(
size,
DEFAULT_CACHE_ENTRY_CHARGE_SIZE,
)),
None => Some(Cache::new_hyper_clock_cache(
DEFAULT_CACHE_SIZE,
DEFAULT_CACHE_ENTRY_CHARGE_SIZE,
)),
};

let mut full_opts = FullOptions::load_from_file(file, cache_size, false)
let mut full_opts = FullOptions::load_from_file_with_cache(file, cache.clone(), false)
.map_err(|err| internal_error(format!("failed to load the options file: {err}")))?;
let cf_names_str: Vec<&str> = cf_names.iter().map(|s| s.as_str()).collect();
full_opts
Expand All @@ -60,8 +69,33 @@ impl RocksDB {
(opts, cf_descriptors)
};

for cf in cf_descriptors.iter_mut() {
let mut block_opts = BlockBasedOptions::default();
block_opts.set_ribbon_filter(10.0);
block_opts.set_index_type(BlockBasedIndexType::TwoLevelIndexSearch);
block_opts.set_partition_filters(true);
block_opts.set_metadata_block_size(4096);
block_opts.set_pin_top_level_index_and_filter(true);
match cache {
Some(ref cache) => {
block_opts.set_block_cache(cache);
block_opts.set_cache_index_and_filter_blocks(true);
block_opts.set_pin_l0_filter_and_index_blocks_in_cache(true);
}
None => block_opts.disable_cache(),
}
// only COLUMN_BLOCK_BODY column family use prefix seek
if cf.name() == "2" {
block_opts.set_whole_key_filtering(false);
cf.options
.set_prefix_extractor(SliceTransform::create_fixed_prefix(32));
}
cf.options.set_block_based_table_factory(&block_opts);
}

opts.create_if_missing(true);
opts.create_missing_column_families(true);
opts.enable_statistics();

let db = OptimisticTransactionDB::open_cf_descriptors(&opts, &config.path, cf_descriptors)
.map_err(|err| internal_error(format!("failed to open database: {err}")))?;
Expand Down
6 changes: 3 additions & 3 deletions resource/ckb.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ dsn = "" # {{
# interval = 600

[db]
# The capacity of RocksDB cache, which caches uncompressed data blocks, indexes and filters, default is 128MB.
# Rocksdb will automatically create and use an 8MB internal cache if you set this value to 0.
# The capacity of RocksDB cache, which caches uncompressed data blocks, indexes and filters, default is 256MB.
# Rocksdb will automatically create and use an 32MB internal cache for each column family by default if you set this value to 0.
# To turning off cache, you need to set this value to 0 and set `no_block_cache = true` in the options_file,
# however, we strongly discourage this setting, it may lead to severe performance degradation.
cache_size = 134217728
cache_size = 268435456

# Provide an options file to tune RocksDB for your workload and your system configuration.
# More details can be found in [the official tuning guide](https://github.com/facebook/rocksdb/wiki/RocksDB-Tuning-Guide).
Expand Down
4 changes: 0 additions & 4 deletions resource/default.db-options
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,3 @@ write_buffer_size=8388608
min_write_buffer_number_to_merge=1
max_write_buffer_number=2
max_write_buffer_size_to_maintain=-1

[TableOptions/BlockBasedTable "default"]
cache_index_and_filter_blocks=true
pin_l0_filter_and_index_blocks_in_cache=true
Loading