Merge pull request #4192 from yangby-cryptape/bugfix/incorrect-checks

fix: incorrect and inadequate checks of sync message
nervosnetwork · Oct 13, 2023 · c9efe08 · c9efe08
2 parents 5dadcbf + f2130fa
commit c9efe08
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/sync/src/synchronizer/mod.rs b/sync/src/synchronizer/mod.rs
@@ -716,7 +716,7 @@ impl CKBProtocolHandler for Synchronizer {
             Ok(msg) => {
                 let item = msg.to_enum();
                 if let packed::SyncMessageUnionReader::SendBlock(ref reader) = item {
-                    if reader.count_extra_fields() > 1 {
+                    if reader.has_extra_fields() || reader.block().count_extra_fields() > 1 {
                         info!(
                             "Peer {} sends us a malformed message: \
                              too many fields in SendBlock",