Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametric editor redesign. #76

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

kamilmadejek
Copy link
Collaborator

@kamilmadejek kamilmadejek commented Jan 13, 2025

This PR introduces a major redesign for configurable editor (see screenshots below).

Expandable sections have been replaced by top-level tabs and hierarchical tree structure of dynamically generated input controls. The new UI is designed to look and feel more modern and clear.


The new editor UI has been implemented for all the Nephio-specific resources, whose editors had been implemented using the configurable editor:

  • req.nephio.org/v1alpha1/Capacity
  • infra.nephio.org/v1alpha1/WorkloadCluster
  • infra.nephio.org/v1alpha1/Network
  • infra.nephio.org/v1alpha1/Token

Remaining editors, which are not implemented using the configurable editor, are intact and still functional using "legacy" UI. This enables us to migrate to a new design in an incremental manner.


Testing (on uitests environment, credentials available per request):


image

image

Copy link

nephio-prow bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamilmadejek
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval by writing /assign @johnbelamaric in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

nephio-prow bot commented Jan 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kamilmadejek kamilmadejek marked this pull request as ready for review January 13, 2025 13:30
@nephio-prow nephio-prow bot requested review from henderiw and liamfallon January 13, 2025 13:30
@radoslawc
Copy link

/test presubmit-kbp-fossology

@radoslawc
Copy link

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants