Language corrections for install guides. #194
Conversation
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
|
Hi @mpgreaves. Thanks for your PR. I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign @efiacor @ciaranjohnston |
| | *DOCKER_REGISTRY_MIRRORS* | List of URLs in | | This variable specifies the list of Docker registry mirrors in JSON format. | | ||
| | | JSON format | | If there are no mirrors to be set, then the variable remains empty. Here are | | ||
| | | | | two example values: ``["https://docker-registry-remote.mycompany.com", | | ||
| | | | | "https://docker-registry-remote2.mycompany.com"]`` | |
There was a problem hiding this comment.
I think we have to add the dummy urls to the ignore list here - https://github.com/nephio-project/docs/blob/main/.linkspector.yml#L10
There was a problem hiding this comment.
It appears that the build does not fail.
There was a problem hiding this comment.
Strange. It failed on the initial commit.
Looks good now.
|
/ok-to-test |
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.