Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase text on Porch main document page #189

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

liamfallon
Copy link
Member

Reword the outlook section of the document.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 9fda7d4
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/674741b49064100008340b9d
😎 Deploy Preview https://deploy-preview-189--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamfallon
Copy link
Member Author

/assign @efiacor @kispaljr @JamesMcDermott

Porch is maintained by the Nephio community and it is core part of the Nephio architecture. Porch will evolve with Nephio and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than "core part" how about "core component" because it is one of the components right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "a core component in"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased it in a commit below. @arora-sagar can you check if you're happy with the rephrased text?

Co-authored-by: JamesMcDermott <james.j.mcdermott@ericsson.com>
@arora-sagar
Copy link
Contributor

/approve

Copy link
Contributor

nephio-prow bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arora-sagar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 27, 2024
@efiacor
Copy link
Contributor

efiacor commented Nov 28, 2024

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Nov 28, 2024
@nephio-prow nephio-prow bot merged commit f6a59b3 into nephio-project:main Nov 28, 2024
9 checks passed
@liamfallon liamfallon deleted the porch-outlook branch December 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants