Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions on Porch Tracing setup added to Porch contributor guide #181

Merged
merged 21 commits into from
Nov 7, 2024
Merged

Instructions on Porch Tracing setup added to Porch contributor guide #181

merged 21 commits into from
Nov 7, 2024

Conversation

liamfallon
Copy link
Member

No description provided.

@nephio-prow nephio-prow bot requested review from arora-sagar and s3wong November 5, 2024 15:36
@netlify Netlify
Copy link

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for nephio ready!

Name Link
🔨 Latest commit c67084c
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/672b40db9d67fd0008691db3
😎 Deploy Preview https://deploy-preview-181--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamfallon
Copy link
Member Author

/assign @CsatariGergely @JamesMcDermott @efiacor @Catalin-Stratulat-Ericsson @kushnaidu

JamesMcDermott
JamesMcDermott reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@JamesMcDermott JamesMcDermott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicky little things...

content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
liamfallon and others added 3 commits November 5, 2024 17:41
@liamfallon @JamesMcDermott
Update content/en/docs/porch/contributors-guide/environment-setup.md
80da77e 
Co-authored-by: JamesMcDermott <james.j.mcdermott@ericsson.com>
@liamfallon @JamesMcDermott
Update content/en/docs/porch/contributors-guide/environment-setup.md
b402240 
Co-authored-by: JamesMcDermott <james.j.mcdermott@ericsson.com>
@liamfallon
Address review comments
4d6b6e9
CsatariGergely
CsatariGergely suggested changes Nov 6, 2024
View reviewed changes
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
liamfallon and others added 14 commits November 6, 2024 09:10
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
cc42935 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
5847caa 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
cdc3422 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
53652ef 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
9672621 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
e798887 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
b56431b 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
87224b8 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
aea85f3 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
db0f3e6 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
84e5a90 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
8734351 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
237b293 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
3c88e1c 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
CsatariGergely suggested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@CsatariGergely CsatariGergely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this way hopefully the text is rendered in aliment with the numbered list of the steps.

content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
content/en/docs/porch/contributors-guide/environment-setup.md Outdated Show resolved Hide resolved
liamfallon and others added 3 commits November 6, 2024 10:04
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
04ee430 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
4fd470f 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon @CsatariGergely
Update content/en/docs/porch/contributors-guide/environment-setup.md
c67084c 
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@efiacor
Copy link
Contributor

efiacor commented Nov 7, 2024

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Nov 7, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 7, 2024
@nephio-prow nephio-prow bot merged commit 9127211 into nephio-project:main Nov 7, 2024
8 checks passed
@liamfallon liamfallon deleted the porch-tracing branch November 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesMcDermott JamesMcDermott JamesMcDermott left review comments

@CsatariGergely CsatariGergely CsatariGergely requested changes

@arora-sagar arora-sagar Awaiting requested review from arora-sagar

@s3wong s3wong Awaiting requested review from s3wong

Assignees

@CsatariGergely CsatariGergely

@efiacor efiacor

@kushnaidu kushnaidu

@Catalin-Stratulat-Ericsson Catalin-Stratulat-Ericsson

@JamesMcDermott JamesMcDermott

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liamfallon @efiacor @CsatariGergely @JamesMcDermott @kushnaidu @Catalin-Stratulat-Ericsson