Adding Porch private authenticated registries functionality documentation #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…henticated repositories
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Catalin-Stratulat-Ericsson
requested review from
liamfallon,
kispaljr,
nagygergo and
efiacor
Catalin-Stratulat-Ericsson
changed the title
Catalin-Stratulat-Ericsson
requested review from
kushnaidu and
JamesMcDermott
CsatariGergely
suggested changes
Oct 22, 2024
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
CsatariGergely
suggested changes
Oct 22, 2024
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
|
/approve |
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-external-private-repositories.md
Outdated
Show resolved
Hide resolved
|
/retest |
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
CsatariGergely
suggested changes
Oct 29, 2024
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
|
/approve |
arora-sagar
reviewed
Oct 30, 2024
| {{% /alert %}} | ||
|
|
||
| This should generate a secret template, similar to the one below, which you can add to the *2-function-runner.yaml* file in the Porch catalog package found [here](https://github.com/nephio-project/catalog/tree/main/nephio/core/porch) | ||
|
|
There was a problem hiding this comment.
@Catalin-Stratulat-Ericsson Secret generated like this kubectl create secret docker-registry XXXX --docker-server=https://index.docker.io/v1/ --docker-username=<your-name> --docker-password=<your-pword> --docker-email=<your-email>
Should also work I suppose? That creates a .dockerconfigjson inside secrets.
There was a problem hiding this comment.
- So long as the content being put into the secret is in the JSON format and follows the docker config.json schema it should work just fine.
- One side note i will say regarding doing it that way is that you would be leaving your password/token in plaintext in the terminal and also in the history of the machine which i don't believe should be encouraged or used as the preferred way to create the secret in the documentation.
There was a problem hiding this comment.
Okay I agree with the second point but we can always remove it from the history using history -d <line-number>
|
/approve |
|
Once --> nephio-project/porch#126 is merged then this PR can be merged |
+1 |
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arora-sagar, JamesMcDermott, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with PR #126
This provides documentation on how to configure porch to use external private authenticated registries.