Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: RedirectAdministrator works as single permission #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markusguenther
Copy link
Member

@markusguenther markusguenther commented Sep 24, 2021

Make that users with just the role RedirectAdministrator can access the backend to be able to create redirects.

redirect-admin.mp4

Fixes: #80

Make that users with just the role RedirectAdministrator can access the backend to be able to create redirects.

Fixes: neos#80
@@ -17,6 +19,10 @@ roles:

'Neos.RedirectHandler.Ui:RedirectAdministrator':
privileges:
- privilegeTarget: 'Neos.Neos:Backend.GeneralAccess'
permission: GRANT
- privilegeTarget: 'Neos.RedirectHandler.Ui:Backend.Module.Management'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply use Neos.Neos:Backend.Module.Management here instead of a new custom privilege target?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that but that did not work 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened when you did?
Did you also adjust the redirect after login setting for Neos?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using Neos.Neos:Backend.Module.Management and Neos.Neos:Backend.GeneralAccess and that should work.

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the default privileges instead of adding a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RedirectAdmin role independent like the UserManager
2 participants