experiment with chunk and block cache #384
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayurii
force-pushed
the
chunk_cache
branch
3 times, most recently
from
1eb438e to
9be2fc2
Compare
khorolets
reviewed
Jan 3, 2025
| pub blocks_cache: std::sync::Arc<crate::cache::RwLockLruMemoryCache<u64, CacheBlock>>, | ||
| pub blocks_cache: | ||
| std::sync::Arc<crate::cache::RwLockLruMemoryCache<u64, near_primitives::views::BlockView>>, | ||
| /// Chunks cache |
There was a problem hiding this comment.
this comment is redundant imo. Alternatively, you can change it to describe the cache if it has something worth mentioning
| @@ -83,18 +86,31 @@ pub struct ServerContext { | |||
|
|
|||
| impl ServerContext { | |||
| pub async fn init(rpc_server_config: configuration::RpcServerConfig) -> anyhow::Result<Self> { | |||
| let contract_code_cache_size_in_bytes = | |||
| utils::gigabytes_to_bytes(rpc_server_config.general.contract_code_cache_size).await; | |||
| // let contract_code_cache_size_in_bytes = | |||
| let contract_code_cache = std::sync::Arc::new(crate::cache::RwLockLruMemoryCache::new( | ||
| contract_code_cache_size_in_bytes, | ||
| )); | ||
|
|
||
| let block_cache_size_in_bytes = | ||
| utils::gigabytes_to_bytes(rpc_server_config.general.block_cache_size).await; | ||
| // let block_cache_size_in_bytes = |
rpc-server/src/config.rs
Outdated
| // let block_cache_size_in_bytes = | ||
| // crate::utils::gigabytes_to_bytes(rpc_server_config.general.block_cache_size).await; | ||
|
|
||
| // For chunk block we use 5GB. make it configurable. temporary hardcoded |
There was a problem hiding this comment.
Suggested change
| // For chunk block we use 5GB. make it configurable. temporary hardcoded | |
| // For chunk block we use 5GB | |
| // TODO: make it configurable. temporary hardcoded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.