Merge pull request #589 from onursumer/fix-plots-tab

Fix broken Plots tab
ncihtan · Feb 23, 2024 · 51f22cb · 51f22cb
2 parents f211211 + 74a78f7
commit 51f22cb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/data-portal-commons/src/lib/entityReportHelpers.ts b/packages/data-portal-commons/src/lib/entityReportHelpers.ts
@@ -117,11 +117,11 @@ export function computeEntityReportByAttribute(
 }
 
 export function getNormalizedOrgan(entity: Entity) {
-    return (
-        tissueOrOriginToOrganMap[
-            normalizeTissueOrOrganOrSite(entity.TissueorOrganofOrigin)
-        ] || entity.TissueorOrganofOrigin
-    );
+    return entity.TissueorOrganofOrigin
+        ? tissueOrOriginToOrganMap[
+              normalizeTissueOrOrganOrSite(entity.TissueorOrganofOrigin)
+          ] || entity.TissueorOrganofOrigin
+        : entity.TissueorOrganofOrigin;
 }
 
 export function getNormalizedAssay(entity: Entity) {

diff --git a/packages/data-portal-explore/src/components/ExplorePlot.tsx b/packages/data-portal-explore/src/components/ExplorePlot.tsx
@@ -76,7 +76,7 @@ function normalizeUnknownValues(
 ) {
     const val = accessor ? accessor(entity) || '' : '';
 
-    if (/^unknown|not reported|^NA/i.test(val.toString())) {
+    if (val === '' || /^unknown|not reported|^NA/i.test(val.toString())) {
         return 'NA';
     } else {
         return val;