Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a checker to validate that q uses SearchFIlter #107

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

smk4664
Copy link
Contributor

@smk4664 smk4664 commented Jan 10, 2025

Closes #99

This PR implements a new checker to validate that Filtersets use SearchFilter for the q search instead of django_filters.CharField with a custom search method.

See prior conversation on #106

@smk4664 smk4664 requested review from cmsirbu, Kircheneer and a team as code owners January 10, 2025 17:49
@smk4664 smk4664 requested a review from glennmatthews January 10, 2025 17:50
Copy link
Collaborator

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@smk4664 smk4664 merged commit f69c28f into develop Jan 10, 2025
15 checks passed
@smk4664 smk4664 deleted the u/smk4664-searchfilter-2 branch January 10, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new linter to ensure filterset q filters are using SearchFilter
2 participants