Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>
  • Loading branch information
smk4664 and gsnider2195 authored Jan 9, 2025
1 parent 1350a0c commit 06b5fdc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion tests/inputs/q-search-filter/error_filter_set.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from nautobot.apps.filters import NautobotFilterSet


class MyAddressObjectFilterSet(NautobotFilterSet):
class IncorrectQFilterTypeFilterSet(NautobotFilterSet):
"""Filter for AddressObject."""

q = django_filters.CharFilter(
Expand Down
2 changes: 1 addition & 1 deletion tests/inputs/q-search-filter/error_filter_set3.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from nautobot.apps.filters import NautobotFilterSet


class MyAddressObjectFilterSet(NautobotFilterSet):
class MissingQFilterFilterSet(NautobotFilterSet):
"""Filter for AddressObject."""

def search(self, queryset, name, value):
Expand Down
2 changes: 1 addition & 1 deletion tests/inputs/q-search-filter/good_filter_set.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from nautobot.apps.filters import NautobotFilterSet, SearchFilter


class MyAddressObjectFilterSet(NautobotFilterSet):
class ValidQFilterFilterSet(NautobotFilterSet):
"""Filter for AddressObject."""

q = SearchFilter(
Expand Down
2 changes: 1 addition & 1 deletion tests/inputs/q-search-filter/good_filter_set3.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from nautobot.apps.filters import NautobotFilterSet, SearchFilter


class MyAddressObjectFilterSet(NautobotFilterSet):
class ValidQFilterWithCustomFilterPredicatesFilterSet(NautobotFilterSet):
"""Filter for AddressObject."""

q = SearchFilter(
Expand Down

0 comments on commit 06b5fdc

Please sign in to comment.