Added test on direct get with subject filter #5953
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alberto Ricart <alberto@synadia.com>
aricart
commented
Oct 2, 2024
| defer sub.Unsubscribe() | ||
| msg, err := sub.NextMsg(10 * time.Millisecond) | ||
| require_NoError(t, err) | ||
| require_Equal(t, "1", msg.Header.Get(JSSequence)) |
There was a problem hiding this comment.
@derekcollison Expected the first message to be sequence 1 - tried with the request being 0 as well. But first message here is always sequence 2 - b
There was a problem hiding this comment.
I think the main issue is that currently the filter for the subjects triggers as a last for subject - but need an option that is simply a subject filter without last semantics. Perhaps this could be aligned with consumer semantics where last_per_subject is a boolean, and we just have a filter_subjects that specifies the filter.
There was a problem hiding this comment.
You need to use NextFor to walk through messages. The one you are using is only for last by subject.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Your Name alberto@nats.io