Add test that shows clfs behavior on dups #5181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
approved these changes
Mar 6, 2024
derekcollison
requested changes
Mar 6, 2024
|
I think the test we want stays under any snapshot limits. Had lots of CLFS increments and then switches leaders. |
wallyqs
force-pushed
the
clfs-on-dups-test
branch
from
9f8fcaa to
66d06f5
Compare
Signed-off-by: Waldemar Quevedo <wally@nats.io>
wallyqs
force-pushed
the
clfs-on-dups-test
branch
from
66d06f5 to
bb404c5
Compare
derekcollison
requested changes
Mar 7, 2024
| var wg sync.WaitGroup | ||
|
|
||
| // The test will be successful if it runs for this long without dup issues. | ||
| ctx, cancel := context.WithTimeout(context.Background(), 1*time.Minute) |
There was a problem hiding this comment.
Can the test be meaningful running for less time?
There was a problem hiding this comment.
In my testing yesterday it was difficult to trip the problem straight away, it would normally need the leader to have bounced around a few times.
There was a problem hiding this comment.
on v2.10.11 it would have happened around the 3rd or 4th leader election in this test
Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.