data processing: making the scripts run with python3 (#768)

* making the scripts run with python3

* making the source noetic instead of kinetic

* make script work in ubuntu 20

* reverting the header change

astrobee/scripts/cpu_print_version.sh

@@ -9,7 +9,7 @@ function deb_version {
   fi
 }
 
-source /opt/ros/kinetic/setup.bash
+source /opt/ros/noetic/setup.bash
 date
 echo "Kernel: $(uname -r)"
 lsb_release -r

hardware/pico_driver/scripts/debug_pico_utils.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

hardware/pico_driver/scripts/pico_check_split_extended.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

hardware/pico_driver/scripts/pico_split_extended.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

hardware/pico_driver/scripts/pico_utils.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

hardware/pico_driver/scripts/pico_write_xyz_coeff.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

localization/sparse_mapping/tools/generate_hugin.py

@@ -144,10 +144,8 @@ def main():
         srcImage.setFilename(img)
         p.addImage(srcImage)
 
-    # make a c++ std::ofstream to write to
-    ofs = ofstream(output_hugin)
     # write the modified panorama to that stream
-    p.writeData(ofs)
+    p.WritePTOFile(output_hugin)
     # done with it
     del ofs
 

scripts/git/pre-commit.linter_python

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
@@ -71,12 +71,18 @@ echo "  Analysing python code style with 'isort'."
 # could happen for example if the .isort.cfg src_paths list gets out
 # of date.
 
-if $(isort . --extend-skip cmake,submodules --profile black --diff --check-only --quiet >/dev/null); then
+isort_args=(
+    "--extend-skip=cmake"
+    "--extend-skip=submodules"
+    "--extend-skip=debian"
+    "--profile=black"
+)
+if $(isort . "${isort_args[@]}" --diff --check-only --quiet >/dev/null); then
     echo "Linter checks using 'isort' passed."
 else
     echo "Errors detected with 'isort'. Fixing them. Try to add and commit your files again."
-  isort . --extend-skip cmake,submodules --profile black >/dev/null
-  failed_lint=true
+    isort . "${isort_args[@]}" >/dev/null
+    failed_lint=true
 fi
 
 # Cancel commit if linter failed

tools/bag_processing/scripts/apply_histogram_equalization_to_images.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/check_bag_for_gaps.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/clock_skew.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/csv_join.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/get_msg_stats.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_debayer.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_detect_bad_topics.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_fix_all.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_merge.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_rewrite_types.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_sample.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_splice.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_topic_filter.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_trim.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/rosbag_verify.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/scripts/utilities/bmr_renumber_enum.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #

tools/bag_processing/test/test_fix_all.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (c) 2017, United States Government, as represented by the
 # Administrator of the National Aeronautics and Space Administration.
 #