properly skip leading spaces in Frame string #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On aarch64 gdb does not start each frame with an address since it can just follow the link register. Skipping characters up to the first '0' is obviously incorrect in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I know I'm the one who changed the thread views 'Frame' string last but I recently got an aarch64 laptop and while running gf on it I noticed what I was doing was incorrect. I also realized it was incorrect for the main thread on amd64 because GDB special cases the thread which contains the 'main' function in it's frame.
I've tested this on both amd64 and aarch64 and this gives the correct results in both cases (just the function's name on aarch64 and the function's address and name on amd64 excluding the main thread which doesn't list the function's address).