fix(editor): Only ignore managed credentials in the HTTP node #12417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
RicardoE105
force-pushed
the
fix-node-credentials
branch
from
74c390c to
0c5d780
Compare
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
mutdmour
approved these changes
Jan 2, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-node-credentials
|
| Run status |
|
| Run duration | 04m 51s |
| Commit |
|
| Committer | Ricardo Espinoza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
484
|
| View all changes introduced in this branch ↗︎ | |
mutdmour
approved these changes
Jan 2, 2025
|
|
mutdmour
approved these changes
Jan 2, 2025
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix of an issue introduced here. This issue is not affecting customers as this version has not been released. Instead of ignoring the managed credentials in all nodes, only do so in the HTTP node.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)