-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prettier #314
Add Prettier #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe its worth only committing the changed files in this PR? and then applying the format in a stacked or followup PR, so that it doesnt crash the github change viewer haha
@TodePond Removed the actual formating changes for now, Can also add them, after approval to this one. (the CI should fail, because of the new linting check). We could also disable the CI, and do the formating in a different PR, I'm fine either way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! if people have trouble with this we could always relax the linting rule
Thanks! I disabled the lint command on CI for now, we should re-enable it again when re-formatting everything in the second PR. |
Changes
npm run lint:fix
for prettier autofixesnpm run lint:check
for checkinglint:fix
to CI runNote
.prettierignore
list