Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier #314

Merged
merged 10 commits into from
Jan 2, 2025
Merged

Add Prettier #314

merged 10 commits into from
Jan 2, 2025

Conversation

reckter
Copy link
Contributor

@reckter reckter commented Dec 30, 2024

Changes

  • Adds .editorconfig with prettier defaults
  • Adds npm run lint:fix for prettier autofixes
  • Adds npm run lint:check for checking
  • Add lint:fix to CI run

Note

  • This does a lot of changes to Markdown files, I don't know enough about how they are used here, to understand if that is problematic. If needed / wanted, we can just put them on the .prettierignore list
  • I've changed no prettier default setting. (I don't like all of the defaults myself, but it's mostly bikeshedding anyway so I thought it best to leave it as is)

Copy link
Contributor

@TodePond TodePond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe its worth only committing the changed files in this PR? and then applying the format in a stacked or followup PR, so that it doesnt crash the github change viewer haha

package.json Outdated Show resolved Hide resolved
@reckter
Copy link
Contributor Author

reckter commented Dec 31, 2024

@TodePond Removed the actual formating changes for now, Can also add them, after approval to this one. (the CI should fail, because of the new linting check). We could also disable the CI, and do the formating in a different PR, I'm fine either way

Copy link
Contributor

@TodePond TodePond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! if people have trouble with this we could always relax the linting rule

@munshkr
Copy link
Owner

munshkr commented Jan 2, 2025

Thanks! I disabled the lint command on CI for now, we should re-enable it again when re-formatting everything in the second PR.

@munshkr munshkr merged commit c786679 into munshkr:main Jan 2, 2025
2 checks passed
@reckter reckter deleted the prettier branch January 2, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants