Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch API: better treat invalid transactions #1428

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

bogdan-rosianu
Copy link
Contributor

@bogdan-rosianu bogdan-rosianu commented Jan 3, 2025

Reasoning

  • invalid transactions(code 400 from gateway) do not throw errors, so they are not properly treated

Proposed Changes

  • if the result of the gateway call does not contain a txHash, mark the batch transaction as invalid

How to test

@bogdan-rosianu bogdan-rosianu self-assigned this Jan 3, 2025
@bogdan-rosianu bogdan-rosianu changed the title better treat invalid transactions Batch API: better treat invalid transactions Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

k6 load testing comparison.
Base Commit Hash: 8135bf8
Target Commit Hash: 4f5e8c1

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Blocks62.221454.1963.0565.4158.571244.9060.2063.33-5.86% ✅-14.39% ✅-4.51% ✅-3.17% ✅
Accounts54.56862.2862.6764.0151.98363.4459.6261.09-4.73% ✅-57.85% ✅-4.86% ✅-4.55% ✅
Mex53.76830.1162.6263.9251.78775.9659.6361.09-3.68% ✅-6.52% ✅-4.77% ✅-4.44% ✅
Nodes53.90751.5462.6163.9551.56121.2559.6861.08-4.35% ✅-83.87% ✅-4.68% ✅-4.48% ✅
Pool54.05539.4762.6363.9452.45789.6259.6661.11-2.96% ✅+46.37% 🔴-4.74% ✅-4.43% ✅
Transactions87.853207.6163.5766.2681.022646.0660.4264.84-7.77% ✅-17.51% ✅-4.96% ✅-2.14% ✅
Tokens54.27669.0462.6563.9352.45702.5659.6461.19-3.36% ✅+5.01% 🔴-4.79% ✅-4.30% ✅
Test Run Duration60002.3260005.86

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@dragos-rebegea dragos-rebegea merged commit 3f7a0b6 into development Jan 8, 2025
5 checks passed
@dragos-rebegea dragos-rebegea deleted the API-364-tx-batch-invalid-txs-fixes branch January 8, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants