Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts endpoint make es heavy fiealds optional #1426

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

dragos-rebegea
Copy link
Contributor

Reasoning

Proposed Changes

How to test

@dragos-rebegea dragos-rebegea marked this pull request as draft December 19, 2024 18:49
Copy link

github-actions bot commented Dec 20, 2024

k6 load testing comparison.
Base Commit Hash: 8135bf8
Target Commit Hash: aca7f5e

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Nodes48.44487.0452.9354.4549.27355.1253.2155.18+1.70% 🔴-27.09% ✅+0.53% 🔴+1.35% 🔴
Transactions64.771999.7372.4276.8663.501669.9354.7674.83-1.97% ✅-16.49% ✅-24.38% ✅-2.65% ✅
Mex48.44832.5352.9254.4349.10131.3953.1755.07+1.35% 🔴-84.22% ✅+0.47% 🔴+1.19% 🔴
Pool48.66799.7352.9054.4349.67821.1653.2355.08+2.07% 🔴+2.68% 🔴+0.62% 🔴+1.18% 🔴
Accounts47.94117.3752.8654.4049.26373.3353.2255.15+2.77% 🔴+218.08% 🔴+0.69% 🔴+1.39% 🔴
Blocks55.581183.3662.9674.8855.04625.5054.4274.39-0.97% ✅-47.14% ✅-13.56% ✅-0.65% ✅
Tokens48.72817.8152.9154.4449.831021.4153.1755.10+2.28% 🔴+24.90% 🔴+0.50% 🔴+1.20% 🔴
Test Run Duration60003.2360002.18

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@dragos-rebegea dragos-rebegea changed the base branch from main to development December 20, 2024 13:34
dragos-rebegea and others added 2 commits December 20, 2024 15:36
…count retrieval. Added tests for withTxCount, withScrCount, withTimestamp, and withAssets parameters, ensuring correct behavior and response structure. Updated existing tests to reflect changes in expected account details when optional parameters are used. Improved overall test coverage for account details retrieval.
@cfaur09 cfaur09 added test Create or update unit / integration tests performance Performance improvement refactoring The same functionality is maintained, but in an improved way labels Dec 23, 2024
@dragos-rebegea dragos-rebegea marked this pull request as ready for review January 8, 2025 14:56
@dragos-rebegea dragos-rebegea merged commit 4ac6654 into development Jan 8, 2025
5 checks passed
@dragos-rebegea dragos-rebegea deleted the accounts-with-optional-fields branch January 8, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvement refactoring The same functionality is maintained, but in an improved way test Create or update unit / integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants