Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate assets cdn #1319

Merged
merged 12 commits into from
Nov 4, 2024
Merged

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Sep 3, 2024

Reasoning

  • refactored asset retrieval process to eliminate dependency on reading from mx-assets repo

Proposed Changes

  • integrate assets-cdn service to read all the informations from assets ( accounts, tokens, identities )

How to test

  • check if assets are retrieved correctly from assets-cdn

@cfaur09 cfaur09 requested a review from tanghel September 3, 2024 10:42
@cfaur09 cfaur09 added the refactoring The same functionality is maintained, but in an improved way label Sep 3, 2024
@cfaur09 cfaur09 self-assigned this Sep 3, 2024
@bogdan-rosianu bogdan-rosianu self-requested a review September 11, 2024 12:54
Copy link

github-actions bot commented Sep 11, 2024

k6 load testing comparison.
Base Commit Hash: 62cef99
Target Commit Hash: 5e54328

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Transactions59.581990.4755.6561.8663.152945.1252.1856.74+6.00% 🔴+47.96% 🔴-6.24% ✅-8.27% ✅
Mex46.90346.7951.3859.4046.83143.7851.3753.78-0.16% ✅-58.54% ✅-0.02% ✅-9.47% ✅
Nodes47.01247.9551.5159.7248.191147.7251.3153.69+2.50% 🔴+362.88% 🔴-0.38% ✅-10.09% ✅
Accounts47.55596.6851.6659.6948.241205.6851.3953.87+1.46% 🔴+102.07% 🔴-0.52% ✅-9.75% ✅
Tokens47.08276.1151.4459.5147.33477.0951.4153.84+0.54% 🔴+72.79% 🔴-0.06% ✅-9.53% ✅
Blocks52.461260.3554.2561.8554.621352.5152.0555.41+4.11% 🔴+7.31% 🔴-4.06% ✅-10.40% ✅
Pool46.90357.2651.4959.4747.12241.5451.3853.77+0.47% 🔴-32.39% ✅-0.22% ✅-9.58% ✅
Test Run Duration60002.7760003.41

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

src/common/assets/assets.service.ts Outdated Show resolved Hide resolved
src/common/assets/assets.service.ts Outdated Show resolved Hide resolved
src/common/assets/assets.service.ts Outdated Show resolved Hide resolved
src/common/assets/assets.service.ts Outdated Show resolved Hide resolved
bogdan-rosianu
bogdan-rosianu previously approved these changes Sep 11, 2024
gabrielmatei
gabrielmatei previously approved these changes Oct 4, 2024
dragos-rebegea
dragos-rebegea previously approved these changes Oct 16, 2024
@dragos-rebegea dragos-rebegea merged commit 759c51e into development Nov 4, 2024
5 checks passed
@dragos-rebegea dragos-rebegea deleted the SERVICES-2563-integrate-assets-cdn branch November 4, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring The same functionality is maintained, but in an improved way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants